This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR preprocessor/7263 - Avoid pedantic warnings on system headers macro tokens


Jason Merrill <jason@redhat.com> writes:

>> +      decl_specs->locations[cpdw_builtin_type_spec] = location;
>>        if (!decl_specs->type)
>>  	{
>>  	  decl_specs->type = type_spec;
>>  	  decl_specs->type_definition_p = false;
>> -	  decl_specs->type_location = location;
>> +	  decl_specs->locations[cpdw_type_spec] = location;
>
> Why do we need cpdw_builtin_type_spec?

To unify the way we access locations for the specifiers.  Otherwise, it
looks awkward to have a lone decl_specs->type_location for the type
specifier, whereas the other specifiers have their locations in
decl_specs->locations.  But if you don't like that, I'll just revert it.

-- 
		Dodji


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]