This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFH / Patch] PR 51222

On 05/01/2012 07:39 PM, Paolo Carlini wrote:
I'm sorry, when a few days ago I noticed that we weren't tsubsting at all I thought the fix would be quite straightforward for me to handle because very local I didn't expect we would go ahead and resolve the FIXME about instantiation-dependent

No worries, thanks for sticking with it.

Maybe we want to gcc_assert ((check_types && !fn) || !check_types) at
the beginning of walk_template_parms. I don't know.

!check_types || !fn, sounds good.

+  if (pfd->check_types && !TYPE_P (t) && TREE_TYPE (t) == NULL_TREE)
+    return error_mark_node;

Let's add a comment like: if the type is null, this is a type-dependent expression, and if we're checking types, we would find the relevant template parameters. And fn must be null, so we can just return.

I think we need to handle FIELD_DECL, too.

Jason

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]