This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] pr51020 Fix invalid options validation for ARM target


On 28/04/12 11:04, Alexey Kravets wrote:
> Hi guys,
> Please, take a look at this patch. It fixes the invalid star symbol
> processing in validate_switches function reported in GCC bugzilla:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51020
> 
> With this patch invalid options are no  longer accepted by the 
> compiler (see new testcase for more details).
> It showed no regressions on GCC-4.6.3 on ARM.
> 
> ChangeLog:
>   * gcc/gcc.c(validate_switches): Reset starred flag.
>   * gcc/testsuite/gcc.target/arm/pr51020.c: New test.
> 

Why have you created an arm-specific test for something that, at least
on initial examination, is a generic issue?

R.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]