This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [v3] is_modulo


On Sat, Apr 28, 2012 at 5:41 PM, Marc Glisse <marc.glisse@inria.fr> wrote:
> Hello,
>
> the attached follows the precisions on the definition of is_modulo in DR
> 612. I believe this is what the values always should have been, so I didn't
> make the change conditional to C++11.

Thanks for the patch.
I think  'char' shouldn't be considered modulo  even if
-funsigned-char -- I will bring this to LWG attention.

>
> PR 22200 can remain open if people want to discuss the interaction with
> -fwrapv, but false is the safe value.

I believe the interaction with -fwrapv is an interesting one.

>
> I ran the testsuite, to make sure there wasn't a huge typo that would
> prevent the file from compiling, and the only failure was the usual
> 22_locale/time_get/get_date/wchar_t/4.cc.

OK.
>
> 2012-04-29 ?Marc Glisse ?<marc.glisse@inria.fr>
>
> ? ? ? ?PR libstdc++/22200
> ? ? ? ?* include/std/limits (numeric_limits<>::is_modulo): false for
> ? ? ? ?signed types.
>
> --
> Marc Glisse


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]