This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: dwarf2out.c: For DWARF 4+, output DW_AT_high_pc as constant offset.


On Fri, 2012-04-27 at 15:43 +0200, Jakub Jelinek wrote:
> On Fri, Apr 27, 2012 at 03:36:56PM +0200, Mark Wielaard wrote:
> > But even without this, I think the patch is worth it just to get rid of
> > all the relocations necessary otherwise.
> 
> IMHO we should defer applying this by a few months, given that GDB support
> is only being added these days and -gdwarf-4 is now the default.
> Applying it in August/September when there is already GDB version with
> the support would be better.

OK, I'll try to remember and ping as soon as a new GDB release is out
with the patch in.

> > +  attr.dw_attr = DW_AT_high_pc;
> > +  if (dwarf_version < 3)
> 
> Shouldn't this be < 4?  I think DWARF 3 doesn't have constant class
> DW_AT_high_pc.

Oops, yes, thanks for spotting.

Cheers,

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]