This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, i386, middle-end, tessuite] Intel TSX's HLE.


On 04/27/12 05:49, Kirill Yukhin wrote:
> +  if (targetm.memmodel_check)
> +    val = targetm.memmodel_check (val);
> +  else if (val & ~MEMMODEL_MASK)
> +
> +    {

Incorrect vertical whitespace.

> +  if ( (failure & MEMMODEL_MASK) == MEMMODEL_RELEASE
> +       || (failure & MEMMODEL_MASK) == MEMMODEL_ACQ_REL)

Incorrect horizontal whitespace.

>        {"generic32", PROCESSOR_GENERIC32, CPU_PENTIUMPRO,
> -	0 /* flags are only used for -march switch.  */ },
> +	PTA_HLE /* flags are only used for -march switch.  */ },
>        {"generic64", PROCESSOR_GENERIC64, CPU_GENERIC64,
> -	PTA_64BIT /* flags are only used for -march switch.  */ },
> +	PTA_64BIT
> +        | PTA_HLE /* flags are only used for -march switch.  */ },

Adding to the generic tunings I suggested.  Removing the HLE
bit from core-avx2 or whatever cpu actually has the bit I did
not suggest.

Otherwise, this looks good.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]