This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [H8300] Use braced strings in MD

From: Jeff Law <law at redhat dot com>
To: "Naveen H. S" <Naveen dot S at kpitcummins dot com>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Mon, 23 Apr 2012 09:48:56 -0600
Subject: Re: [H8300] Use braced strings in MD
References: <5CD0E437A05A514A90A1B12527F331542C0F6C11@KCHJEXMB01.kpit.com> <4F91D3FE.6020007@redhat.com> <5CD0E437A05A514A90A1B12527F331542C0F6E2A@KCHJEXMB01.kpit.com>

On 04/23/2012 12:17 AM, Naveen H. S wrote:

Some of my colleagues here do have checkin rights but not me.
I have now requested for checkin after approval rights.
Is this ok?

Great. I approved it this morning and it looks like your account was created soon thereafter. Please add yourself to the MAINTAINTERS file with write-after-approval privileges.

Done. Braces are indented except for "define_insn" where they start at
column 0.

Thanks.

The mis-indented braces in h8300.md are fixed as per my knowledge.
Please review the attached patch and let me know if it's OK to commit
with these changes?

Looks good. Please install. Similarly for the v850 changes.

Thanks!

jeff

Follow-Ups:
- RE: [H8300] Use braced strings in MD
  - From: Naveen H. S

References:
- [H8300] Use braced strings in MD
  - From: Naveen H. S
- Re: [H8300] Use braced strings in MD
  - From: Jeff Law
- RE: [H8300] Use braced strings in MD
  - From: Naveen H. S

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]