This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [H8300] Use braced strings in MD


Hi,

>> This is fine. 

Thanks for reviewing the changes and your suggestions.

>> Do you have checkin privs for the GCC repository?  
>> If not, please request them so you can check in your patches.

Some of my colleagues here do have checkin rights but not me.
I have now requested for checkin after approval rights.
Is this ok?

>> Like Mike, I think the braces ought to be indented

Done. Braces are indented except for "define_insn" where they start at
column 0.

>> but there's a multitude of mis-indented braces in h8300.md already. 
>> If you wanted to fix up that aspect of formatting the md file, that'd 
>> be a fine follow-up patch.

The mis-indented braces in h8300.md are fixed as per my knowledge.
Please review the attached patch and let me know if it's OK to commit
with these changes?

Thanks & Regards,
Naveen

Attachment: h8_indent.patch
Description: h8_indent.patch


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]