This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PING: [PATCH] Fix PRs c/52283/37985


On 19 April 2012 11:11, Christian Bruel <christian.bruel@st.com> wrote:
>
>
> On 04/18/2012 11:51 AM, Richard Guenther wrote:
>> On Wed, Apr 18, 2012 at 11:06 AM, Manuel López-Ibáñez
>> <lopezibanez@gmail.com> wrote:
>>> On 18 April 2012 10:29, Christian Bruel <christian.bruel@st.com> wrote:
>>>>
>>>> Is it OK for trunk, bootstrapped and regtested on x86
>>>
>>> I think Joseph Myers is on vacation, and there are no other C FE
>>> reviewers, but since this is c-common and convert.c, perhaps Jason
>>> and/or Richard can review it?
>>
>> The patch is ok if you put the PR52283 properly into a separate testcase,
>> not by amending gcc.dg/case-const-2.c.
>>
>
> Thanks, done at rev #186586. with this change.

Great!

Just a minor nit, for future patches. There is the unwritten rule of
adding the Changelogs to the commit log, like follows:

2012-04-19  Christian Bruel  <christian.bruel@st.com>
                  Manuel López-Ibáñez  <manu@gcc.gnu.org>

       PR c/52283
       PR c/37985
       * stmt.c (warn_if_unused_value): Skip NOP_EXPR.
       * convert.c (convert_to_integer): Don't set TREE_NO_WARNING.
testsuite/
       * gcc.dg/pr52283.c: New test.
       * gcc.dg/pr37985.c: New test.


Also, if you add to the commit logs the PR numbers like:
PR whatever/NUMBER
PR whatever2/NUMBER

then bugzilla will show the commit on each PR.

Cheers,

Manuel.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]