This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [google/google-main] Fix for unused variable warning in libgcov.c (issue6052049)
- From: Xinliang David Li <davidxl at google dot com>
- To: Teresa Johnson <tejohnson at google dot com>
- Cc: reply at codereview dot appspotmail dot com, gcc-patches at gcc dot gnu dot org
- Date: Tue, 17 Apr 2012 11:57:13 -0700
- Subject: Re: [google/google-main] Fix for unused variable warning in libgcov.c (issue6052049)
- References: <20120417184008.7774261595@tjsboxrox.mtv.corp.google.com>
ok.
David
On Tue, Apr 17, 2012 at 11:40 AM, Teresa Johnson <tejohnson@google.com> wrote:
> I have a patch to fix a compile time warning about an unused variable due
> to the use being guarded by #ifndef __GCOV_KERNEL__.
>
> Tested with bootstrap. Ok for google-main?
>
> Teresa
>
> 2012-04-17 ? Teresa Johnson ?<tejohnson@google.com>
>
> ? ? ? ?Google ref b/5910724.
> ? ? ? ?* libgcc/libgcov.c (gcov_cur_module_id): Guard definition under
> ? ? ? ?#ifndef __GCOV_KERNEL__.
>
> Index: libgcov.c
> ===================================================================
> --- libgcov.c ? (revision 186282)
> +++ libgcov.c ? (working copy)
> @@ -153,10 +153,10 @@ static gcov_unsigned_t gcov_crc32;
>
> ?/* Size of the longest file name. */
> ?static size_t gcov_max_filename = 0;
> -#endif /* __GCOV_KERNEL__ */
>
> ?/* Unique identifier assigned to each module (object file). ?*/
> ?static gcov_unsigned_t gcov_cur_module_id = 0;
> +#endif /* __GCOV_KERNEL__ */
>
> ?/* Pointer to the direct-call counters (per call-site counters).
> ? ?Initialized by the caller. ?*/
>
> --
> This patch is available for review at http://codereview.appspot.com/6052049