This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, i386, Android] Add Android support for i386 target


> On Tue, Apr 17, 2012 at 3:16 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
>> On Tue, Apr 17, 2012 at 12:16 PM, Ilya Enkovich <enkovich.gnu@gmail.com> wrote:
>>>>>
>>>>> It has nothing but defines for Android. It did not move any existing
>>>>> code to this file.
>>>>>
>>>>
>>>> Adding linux-common.h to i386 backend needs approval from
>>>> i386 backend maintainer. ? If a patch also adds Android support,
>>>> i386 backend maintainer may not feel comfortable to review it.
>>>> However, if you simplify add linux-common.h with XXX_SPEC,
>>>> i386 backend maintainer can review it easily.
>>>>
>>>> --
>>>> H.J.
>>>
>>> All XXX_SPEC in linux-common.h are Android related. I also believe
>>> that my Android specific changes need i386 backend maintainer approval
>>> anyway because wrong Android support implementation may break other
>>> targets.
>>
>> +#undef ?ENDFILE_SPEC
>> +#define ENDFILE_SPEC \
>> + ?GNU_USER_TARGET_MATHFILE_SPEC " " \
>> + ?GNU_USER_TARGET_ENDFILE_SPEC
>>
>> Where is GNU_USER_TARGET_ENDFILE_SPEC defined?
>
> Oh, I found it.
>
> The patch looks OK to me in the sense, that there is no difference for
> x86 targets.
>
> So, OK for x86.
>
> Thanks,
> Uros.

Thanks, Uros!

Maxim, could you please look at patch?

Thanks,
Ilya


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]