This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Change initialization order in sel-sched

From: Bernd Schmidt <bernds at codesourcery dot com>
To: Alexander Monakov <amonakov at ispras dot ru>
Cc: Richard Guenther <richard dot guenther at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Andrey Belevantsev <abel at ispras dot ru>
Date: Tue, 17 Apr 2012 15:36:17 +0200
Subject: Re: Change initialization order in sel-sched
References: <4F859244.9060600@codesourcery.com> <CAFiYyc1dDJ0iC+tVqU6foXUvyzzNfae9ZkHPRS5-gSXjRfMqUg@mail.gmail.com> <alpine.LNX.2.00.1204171712550.25110@monoid.intra.ispras.ru>

On 04/17/2012 03:33 PM, Alexander Monakov wrote:
> Bernd, could you elaborate on the segfault you had seen?  Perhaps we could
> offer some advice on fixing it then.

It was only seen with another patch which modified the sched-rgn
initialization code.

> In the meanwhile, could you revert your patch?  I'm sorry to point out this
> problem after the patch had been committed, but it's not immediately obvious :)
> Andrey or I will add an explanatory comment in sel-sched afterwards.

Will revert for now. In general I think it would be better to change
sel-sched so that the init functions can always be called in the same
order, so as to avoid unnecessary surprises.

Bernd

References:
- Change initialization order in sel-sched
  - From: Bernd Schmidt
- Re: Change initialization order in sel-sched
  - From: Richard Guenther
- Re: Change initialization order in sel-sched
  - From: Alexander Monakov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]