This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 03/11] Fix PCH crash on GTYed pointer-to-scalar field of a


2012 m. balandis 10 d. 18:08, Dodji Seketeli <dodji@redhat.com> raÅÄ:
> gcc/
>
> Â Â Â Â* gengtype.c (write_types_process_field): ÂForce second argument
> Â Â Â Âof the call to the PCH object hierarchy walker to be 'x'.


I guess it'd be better if we separated prev_val[3] and constant "x"
uses to separate walk_type_data fields, and I'm not sure if the fix is
complete (well it is for the current usage, isn't it), but the patch
is certainly OK. Thank you.

-- 
Laurynas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]