This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Caret diagnostics
On 8 April 2012 18:35, Gabriel Dos Reis <email@example.com> wrote:
> On Sun, Apr 8, 2012 at 11:13 AM, Manuel LÃpez-IbÃÃez
> <firstname.lastname@example.org> wrote:
>> On 8 April 2012 06:09, Jason Merrill <email@example.com> wrote:
>>> On 04/07/2012 06:29 PM, Manuel LÃpez-IbÃÅez wrote:
>>>> +getenv_columns (void)
>>> I had been thinking to check COLUMNS once at the beginning of compilation; I
>>> don't think the value can change while the compiler is running since we
>>> don't respond to SIGWINCH. ÂAnd let's use this value in
>>> c_common_initialize_diagnostics, too.
>> To focus on the issue at hand, and independently of whether any bugs
>> exist or not, and whether I am capable or not to fix them. What you
>> are proposing is to change the current default of no line-wrapping to
>> line-wrap at getenv("COLUMNS"), isn't it?
OK, so to do this, I have to figure out where the pretty-printer is
initialized in each FE. For C++ there are two different places:
init_error() initializes cxx_pp
whereas cxx_initialize_diagnostics seems to initialize a different
pretty-printer for C++.
What is the difference between the two?