This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Caret diagnostics


On 8 April 2012 18:35, Gabriel Dos Reis <gdr@integrable-solutions.net> wrote:
> On Sun, Apr 8, 2012 at 11:13 AM, Manuel LÃpez-IbÃÃez
> <lopezibanez@gmail.com> wrote:
>> On 8 April 2012 06:09, Jason Merrill <jason@redhat.com> wrote:
>>> On 04/07/2012 06:29 PM, Manuel LÃpez-IbÃÅez wrote:
>>>
>>>> +getenv_columns (void)
>>>
>>>
>>> I had been thinking to check COLUMNS once at the beginning of compilation; I
>>> don't think the value can change while the compiler is running since we
>>> don't respond to SIGWINCH. ÂAnd let's use this value in
>>> c_common_initialize_diagnostics, too.
>>>
>>
>> To focus on the issue at hand, and independently of whether any bugs
>> exist or not, and whether I am capable or not to fix them. What you
>> are proposing is to change the current default of no line-wrapping to
>> line-wrap at getenv("COLUMNS"), isn't it?
>
> yes.

OK, so to do this, I have to figure out where the pretty-printer is
initialized in each FE. For C++ there are two different places:

init_error() initializes cxx_pp
whereas cxx_initialize_diagnostics seems to initialize a different
pretty-printer for C++.

What is the difference between the two?

Cheers,

Manuel.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]