This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Caret diagnostics


On 04/07/2012 06:29 PM, Manuel López-Ibáñez wrote:
I'll be happy to change it to whatever is more understandable. I think
in CSS is called "padding".

That wouldn't be any clearer; my confusion was that I thought you were padding the right side of the source line, but you aren't; you are only making sure that the caret isn't too close to the edge of the terminal. No need to change anything here.


+getenv_columns (void)

I had been thinking to check COLUMNS once at the beginning of compilation; I don't think the value can change while the compiler is running since we don't respond to SIGWINCH. And let's use this value in c_common_initialize_diagnostics, too.


+ # Also it may trim a source line by mistake since it matches repeated lines.

Let's clarify this comment; because dejagnu gets the whole compiler output as a single string, .* in a test regexp can match across multiple lines, which with caret diagnostics is likely to mean that the beginning of the regexp matches the error message and the end of the regexp matches the regexp itself in the printed source line.


Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]