This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Caret diagnostics

On 7 April 2012 04:31, Jason Merrill <> wrote:
> On 04/06/2012 06:30 PM, Manuel López-Ibáñez wrote:
>>> width if it's set; otherwise I would lean toward unlimited width. And I'm
>>> not sure why we need a right margin at all.
>> The right margin is because:
> Ah, I read "margin" and assumed it meant you were leaving blank space at the
> right side of the screen. ?Now I understand.

I'll be happy to change it to whatever is more understandable. I think
in CSS is called "padding".

New version attached. Bootstrapped and regression tested including obj-c++.



2012-04-05  Manuel López-Ibáñez  <>

	PR 24985
	* testsuite/lib/prune.exp: Handle caret.
	* testsuite/lib/libmudflap.exp: Handle caret.
        * diagnostic.h (show_caret): Declare.
	(diagnostic_show_locus): Declare.
        * diagnostic.c (diagnostic_initialize): Initialize to false.
        (diagnostic_show_locus): New.
        (diagnostic_report_diagnostic): Call it.
	(getenv_columns): New function.
        * input.c (read_line): New.
	(location_get_source_line): New.
        * input.h (location_get_source_line): Declare.
        * toplev.c (general_init): Initialize show_caret from options.
        * dwarf2out.c (gen_producer_string): Handle fdiagnostics-show-caret.
        * opts.c (common_handle_option): Likewise.
        * common.opt (fdiagnostics-show-caret): New option.
        * testsuite/lib/prune.exp: Add -fno-diagnostics-show-caret.

Attachment: caret-diagnostics-20120408.diff
Description: Binary data

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]