This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Caret diagnostics


On 04/06/2012 04:11 AM, Manuel López-Ibáñez wrote:
+++ gcc/testsuite/gcc.dg/torture/tls/tls.exp	(working copy)
@@ -48,10 +48,10 @@ dg-init
 torture-init
 set-torture-options $TLS_TORTURE_OPTIONS {{}} $LTO_TORTURE_OPTIONS

 # Main loop.
 gcc-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cS\]]] \
-        $DEFAULT_CFLAGS
+        "-fno-diagnostics-show-caret $DEFAULT_CFLAGS"

I don't think this is needed since you're already adding it to TEST_ALWAYS_FLAGS. The tests pass without this for me.


+ int max_width = 80, right_margin = 10;

Let's not hardcode these numbers. We should use getenv("COLUMNS") for the width if it's set; otherwise I would lean toward unlimited width. And I'm not sure why we need a right margin at all.


+  s = expand_location(diagnostic->location);
+  line = location_get_source_line (s);

Why not expand the location inside location_get_source_line?


Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]