This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Caret diagnostics


On 6 April 2012 15:42, Mike Stump <mikestump@comcast.net> wrote:
> On Apr 6, 2012, at 1:11 AM, Manuel López-Ibáñez wrote:
>> A simple implementation of caret diagnostics.
>>
>> In the testsuite, pruning the caret output does not always work
>> because of several known deficiencies of DejaGNU, thus in some places
>> I disable the caret explicitly.
>>
>> Bootstrapped and regression tested on x86_64-unknown-gnu-linux with
>> enable-languages=all,ada and -m32/-m64.
>>
>> OK to commit?
>
> Could someone take Objective-C++ for a spin? ?It builds and runs pretty quickly, non-bootstrap is fine.
>
> The testsuite changes are fine, though, it feels like you're missing the main prune routine?

I didn't change the prune routine because it doesn't work reliably
(because of DejaGNU problems PR12096 and PR30612 and others mentioned
in PR24985). That is why I set -fno-diagnostics-show-caret there.
Other places that have their own prune routines didn't show any
problems, so I prune the output instead of adding
-fno-diagnostics-show-caret to every command.

> Nice work, love to see it go in.

Thanks,

Manuel.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]