This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Define TRY_EMPTY_VM_SPACE for Linux/x32


On Thu, Apr 5, 2012 at 3:28 PM, H.J. Lu <hjl.tools@gmail.com> wrote:

>>>> Looking at how other targets implement this check, I don't think that
>>>> this is a problem at all. This issue only shows on a non-bootstrapped
>>>> build. A full bootstrap will use correct address.
>>>
>>> The other place where it shows up is cross compilers but who is going
>>> to use a 3.2 compiler with GCC 4.8 anyways?
>>>
>>
>> FWIW, I have no problem with checking __LP64__ only. I just want to
>> mention this potential issue.
>>
>
> Here is a different patch. ?It checks sizeof (void *) for those hosts
> where it is appropriate. ?Does it look OK?

Looks OK to me, but you need a GWP reviewer to OK this change now...

Thanks,
Uros.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]