This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/2] arm: add iwMMXt mmx-2.c test
- From: Ramana Radhakrishnan <ramana dot radhakrishnan at linaro dot org>
- To: Matt Turner <mattst88 at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Nick Clifton <nickc at redhat dot com>, Richard Earnshaw <richard dot earnshaw at arm dot com>, Paul Brook <paul at codesourcery dot com>, Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>
- Date: Thu, 5 Apr 2012 09:53:28 +0100
- Subject: Re: [PATCH 2/2] arm: add iwMMXt mmx-2.c test
- References: <1333564533-26841-1-git-send-email-mattst88@gmail.com>
On 4 April 2012 19:35, Matt Turner <mattst88@gmail.com> wrote:
>
> ?gcc/testsuite/gcc.target/arm/mmx-2.c | ?158 ++++++++++++++++++++++++++++++++++
> ?1 files changed, 158 insertions(+), 0 deletions(-)
> ?create mode 100644 gcc/testsuite/gcc.target/arm/mmx-2.c
>
> diff --git a/gcc/testsuite/gcc.target/arm/mmx-2.c b/gcc/testsuite/gcc.target/arm/mmx-2.c
> new file mode 100644
> index 0000000..603a63b
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/arm/mmx-2.c
> @@ -0,0 +1,158 @@
> +/* { dg-do compile } */
> +/* { dg-skip-if "Test is specific to the iWMMXt" { arm*-*-* } { "-mcpu=*" } { "-mcpu=iwmmxt" } } */
> +/* { dg-skip-if "Test is specific to the iWMMXt" { arm*-*-* } { "-mabi=*" } { "-mabi=iwmmxt" } } */
> +/* { dg-skip-if "Test is specific to the iWMMXt" { arm*-*-* } { "-march=*" } { "-march=iwmmxt" } } */
> +/* { dg-skip-if "Test is specific to ARM mode" { arm*-*-* } { "-mthumb" } { "" } } */
How about simplifying this with a dg-require-effective-target
arm_arm_ok instead of doing
dg-require-effective-target arm32 and then skipping it for Thumb2 ?
Otherwise looks OK to me. Please don't commit any of these patches
till your copyright assignment is sorted -
Thanks,
Ramana