This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [branches/google/gcc-4_6] Backported r179661 and 179662 from mainline. (issue 5989043)


On 5 April 2012 15:56,  <asharif@chromium.org> wrote:
> Reviewers: Diego Novillo, jingyu, davidxl,
>
> Message:
> Please take a look at this patch and tell me if it's OK for
> branches/google/gcc-4_6.
>
> Description:
> Backported the following patch from trunk:
>
> 2011-10-07 ?Andrew Stubbs ?<ams@codesourcery.com>
>
> ? ?gcc/
> ? ?* config/arm/predicates.md (shift_amount_operand): Remove constant
> ? ?range check.
> ? ?(shift_operator): Check range of constants for all shift operators.
>
> ? ?gcc/testsuite/
> ? ?* gcc.dg/pr50193-1.c: New file.
> ? ?* gcc.target/arm/shiftable.c: New file.
>
>
> Please review this at http://codereview.appspot.com/5989043/
>
> Affected files:
> ? M ? ?.
> ?M ? ? gcc/ChangeLog
> ?M ? ? gcc/ChangeLog.google-4_6
> ?M ? ? gcc/config/arm/predicates.md
> ?M ? ? gcc/testsuite/ChangeLog
> ?A ?+ ?gcc/testsuite/gcc.dg/pr50193-1.c
> ?A ?+ ?gcc/testsuite/gcc.target/arm/shiftable.c

Andrew, could you check that the Google guys have the final version of
your patch?

Could you backport the fix to the 4.6 release branch if valid?  Better
than having the same patch in three places.

-- Michael


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]