This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [branches/google/gcc-4_6] Backported r179661 and 179662 from mainline. (issue 5989043)
- From: Michael Hope <michael dot hope at linaro dot org>
- To: Andrew Stubbs <andrew dot stubbs at linaro dot org>
- Cc: asharif at chromium dot org, dnovillo at google dot com, jingyu at google dot com, davidxl at google dot com, gcc-patches at gcc dot gnu dot org, reply at codereview-hr dot appspotmail dot com
- Date: Thu, 5 Apr 2012 16:43:45 +1200
- Subject: Re: [branches/google/gcc-4_6] Backported r179661 and 179662 from mainline. (issue 5989043)
- References: <20cf30563c1f7d9ce504bce68701@google.com>
On 5 April 2012 15:56, <asharif@chromium.org> wrote:
> Reviewers: Diego Novillo, jingyu, davidxl,
>
> Message:
> Please take a look at this patch and tell me if it's OK for
> branches/google/gcc-4_6.
>
> Description:
> Backported the following patch from trunk:
>
> 2011-10-07 ?Andrew Stubbs ?<ams@codesourcery.com>
>
> ? ?gcc/
> ? ?* config/arm/predicates.md (shift_amount_operand): Remove constant
> ? ?range check.
> ? ?(shift_operator): Check range of constants for all shift operators.
>
> ? ?gcc/testsuite/
> ? ?* gcc.dg/pr50193-1.c: New file.
> ? ?* gcc.target/arm/shiftable.c: New file.
>
>
> Please review this at http://codereview.appspot.com/5989043/
>
> Affected files:
> ? M ? ?.
> ?M ? ? gcc/ChangeLog
> ?M ? ? gcc/ChangeLog.google-4_6
> ?M ? ? gcc/config/arm/predicates.md
> ?M ? ? gcc/testsuite/ChangeLog
> ?A ?+ ?gcc/testsuite/gcc.dg/pr50193-1.c
> ?A ?+ ?gcc/testsuite/gcc.target/arm/shiftable.c
Andrew, could you check that the Google guys have the final version of
your patch?
Could you backport the fix to the 4.6 release branch if valid? Better
than having the same patch in three places.
-- Michael