This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [google/4.6] For -gfission, remove address table entry when removing location list entry (issue5900045)
- From: Sterling Augustine <saugustine at google dot com>
- To: Cary Coutant <ccoutant at google dot com>
- Cc: reply at codereview dot appspotmail dot com, gcc-patches at gcc dot gnu dot org
- Date: Fri, 23 Mar 2012 15:45:52 -0700
- Subject: Re: [google/4.6] For -gfission, remove address table entry when removing location list entry (issue5900045)
- References: <20120323224014.8AE00E1683@ccoutant.mtv.corp.google.com>
On Fri, Mar 23, 2012 at 3:40 PM, Cary Coutant <ccoutant@google.com> wrote:
>
> 2012-03-23 ? Cary Coutant ?<ccoutant@google.com>
>
> ? ? ? ?* dwarf2out.c (resolve_addr): Remove address table entry for symbol
> ? ? ? ?when removing location list entry.
>
>
> Index: dwarf2out.c
> ===================================================================
> --- dwarf2out.c (revision 185594)
> +++ dwarf2out.c (working copy)
> @@ -23803,11 +23803,15 @@ resolve_addr (dw_die_ref die)
> ? ? ? ? ? ? ? ?if (!resolve_addr_in_expr ((*curr)->expr))
> ? ? ? ? ? ? ? ? ?{
> ? ? ? ? ? ? ? ? ? ?dw_loc_list_ref next = (*curr)->dw_loc_next;
> + ? ? ? ? ? ? ? ? ? dw_loc_descr_ref l = (*curr)->expr;
> +
> ? ? ? ? ? ? ? ? ? ?if (next && (*curr)->ll_symbol)
> ? ? ? ? ? ? ? ? ? ? ?{
> ? ? ? ? ? ? ? ? ? ? ? ?gcc_assert (!next->ll_symbol);
> ? ? ? ? ? ? ? ? ? ? ? ?next->ll_symbol = (*curr)->ll_symbol;
> ? ? ? ? ? ? ? ? ? ? ?}
> + ? ? ? ? ? ? ? ? ? if (l->dw_loc_oprnd1.val_index != -1U)
> + ? ? ? ? ? ? ? ? ? ? remove_addr_table_entry
> (l->dw_loc_oprnd1.val_index);
> ? ? ? ? ? ? ? ? ? ?*curr = next;
> ? ? ? ? ? ? ? ? ?}
> ? ? ? ? ? ? ? ?else
>
> --
> This patch is available for review at
> http://codereview.appspot.com/5900045
This patch is OK for Google 4.6.
Sterling