This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Do not use lang_hooks.types.type_for_size in signed_or_unsigned_type_for
On Wed, 7 Mar 2012, Michael Matz wrote:
> Hi,
>
> On Wed, 7 Mar 2012, Richard Guenther wrote:
>
> > FAIL: gcc.dg/tree-ssa/pr31261.c scan-tree-dump-times original "return
> > \\(char\\)
> > -\\(unsigned char\\) c & 31;" 1
> > FAIL: gcc.dg/tree-ssa/pr31261.c scan-tree-dump-times original "return
> > \\(int\\)
> > \\(12 - \\(unsigned int\\) d\\) & 7;" 1
> >
> > because we dump the unsigned type variant differently now. What do
> > people think - adjust the testcase? Adjust how we pretty-print
> > these non-standard integer types?
>
> Adjusting the pretty printer would be nice anyway. Those <unnamed>:35
> thingies hurt my eyes. Just printing int17 or uint18 would be perfectly
> fine, with special casing of sizes that match the normal C types for
> the target in question (so that input 'unsigned char' isn't converted to
> 'uint8' on one and 'uint16' on another target).
Ok, I'll do that (special-casing some precisions via *_TYPE_SIZE).
I won't touch the <unnamed-unsigned-type:35> stuff, for now.
Richard.