This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch,AVR]: Fix PR50063 GCC does not support FP = SP
- From: Denis Chertykov <chertykov at gmail dot com>
- To: Richard Henderson <rth at redhat dot com>
- Cc: Georg-Johann Lay <avr at gjlay dot de>, Jakub Jelinek <jakub at redhat dot com>, gcc-patches at gcc dot gnu dot org, Eric Weddington <eric dot weddington at atmel dot com>
- Date: Tue, 21 Feb 2012 23:18:05 +0400
- Subject: Re: [Patch,AVR]: Fix PR50063 GCC does not support FP = SP
- Authentication-results: mr.google.com; spf=pass (google.com: domain of chertykov@gmail.com designates 10.152.144.4 as permitted sender) smtp.mail=chertykov@gmail.com; dkim=pass header.i=chertykov@gmail.com
- References: <4F438248.70503@gjlay.de> <20120221115235.GA18768@tyan-ft48-01.lab.bos.redhat.com> <4F43CF99.2040706@gjlay.de> <4F43D2CD.9080507@redhat.com>
2012/2/21 Richard Henderson <rth@redhat.com>:
> On 02/21/12 09:08, Georg-Johann Lay wrote:
>> Â Â Â PR rtl-optimization/50063
>> Â Â Â * config/avr/avr.md (movhi_sp_r): Handle -1 (unknown IRQ state)
>> Â Â Â and 2 (8-bit SP) in operand 2.
>> Â Â Â * config/avr/avr.c (avr_prologue_setup_frame): Adjust prologue
>> Â Â Â setup to use movhi_sp_r instead of vanilla move to write SP.
>> Â Â Â Adjust REG_CFA notes to superseed unspec.
>> Â Â Â (expand_epilogue): Adjust epilogue setup to use read_sp instead
>> Â Â Â of vanilla move.
>> Â Â Â As function body might contain CLI or SEI: Use irq_state 0 (IRQ
>> Â Â Â known to be off) only with TARGET_NO_INTERRUPTS. Never use
>> Â Â Â irq_state 1 (IRQ known to be on) here.
>
> The CFA bits in avr_prologue_setup_frame look good.
> I'll let Denis or Eric review the movhi_sp_r change.
>
Approved.
Denis.