This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix cgraph verification (PR middle-end/51929)

> On Tue, Feb 14, 2012 at 11:12:31AM -0800, Jason Merrill wrote:
> > On 02/10/2012 06:25 AM, Jakub Jelinek wrote:
> > >	PR middle-end/51929
> > >	* cgraphunit.c (verify_edge_corresponds_to_fndecl): If node is
> > >	a same_body_alias, also test whether e->callee isn't a former
> > >	or current clone of the decl this is a same body alias of.
> > 
> > Do we want a similar change to the use of former_clone_of in
> > cgraph_update_edges_for_call_stmt_node?  Maybe we should wrap the
> I don't think so.  new_call in that case is what we are changing the
> call to, and we should never change some call into a call to same body alias
> function, calls to same body alias functions should be just those that
> haven't been changed yet.

Yes, I think cgraph_update_edges_for_call_stmt_node is fine here.
I am not sure how long we will be able to maintain the edges sanity check.
It is useful, but as we start doing more and more involved redirections we
may need to disable it eventually.

> > former_clone_of checking in a function to make that simpler.
> 	Jakub

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]