This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [patch] clean up pdp11.md a bit
These look fine. I'll defer to others on whether it should wait to Phase 1.
I had tried to make divmod work but never figured out the reason why it did not. Thanks for answering that question.
As for the subregs that Richard commented on -- I will gladly admit that this target isn't all clean yet. So that goes onto the list of things to work on, too.
paul
-----Original Message-----
From: Steven Bosscher [mailto:stevenb.gcc@gmail.com]
Sent: Tuesday, February 14, 2012 5:09 PM
To: Koning, Paul; GCC Patches
Subject: [patch] clean up pdp11.md a bit
Hello,
Just a few cleanups for things I noticed last weekend.
* Constraints on define_expand are never used, remove them (most other ports do not have constraints on define_expands either)
* Some patterns have no name, makes debugging a bit harder
* The divmodhi4 expander has been commented out since Day 1 of egcs.
Explain why.
Tested by building the compiler. For pdp11-elf, which is not a supported target according to backends.html, but it's not rejected.
Not sure what the right target is to compile for. In any case, I obviously have no PDP-11 to test on. But the patch has no changes that impact code generation (the constraints were already ignored).
OK for trunk?
Ciao!
Steven