This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [Patch,AVR]: Built-in for non-contiguous port layouts


> -----Original Message-----
> From: Georg-Johann Lay 
> Sent: Tuesday, February 14, 2012 10:52 AM
> To: Weddington, Eric
> Cc: gcc-patches@gcc.gnu.org; Denis Chertykov
> Subject: Re: [Patch,AVR]: Built-in for non-contiguous port layouts
> 
> Weddington, Eric wrote:
> >
> >>
> >> This patch set removes __builtin_avr_map8 __builtin_avr_map16
> >> built-ins and implements a built-in __builtin_avr_insert_bits
instead.
> >>
> >
> > In your avr_fold_builtin function you have switch (fcode) with only
one
> > case (and a "default" that just breaks). Are you planning to add
more
> > cases in the near future? If not, wouldn't it be better to just make
it
> > an 'if' statement?
> 
> The intention was to facilitate adding of other folds by means of
other case
> entries.  Folding swap is pretty much trivial for example.  And
someone
> proposed adding things like __builtin_avr_memx_flash_p resp.
> __builtin_avr_memx_ram_p that could also be folded easily.
> 

Ok, thanks. Please commit.

Eric


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]