This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] avoid '//' prefixes when sysroot is set to '/'


On 26.01.2012 18:57, Joseph S. Myers wrote:
On Thu, 26 Jan 2012, Matthias Klose wrote:

On 25.01.2012 17:45, Joseph S. Myers wrote:
On Wed, 25 Jan 2012, Matthias Klose wrote:

This can end up in generation for dependency files, and other files
parsing
the output. The solution I came up with is to check for sysroot set to '/'
and
special case this in two places. Afaics, there are no other places.

I could imagine a sysroot path that isn't just '/' but ends with '/' resulting in duplicate '/' in the middle of the path - although that's not a correctness issue in the way that '//' at the start could be, maybe the best check is actually for '/' at end of sysroot (in which case skip the '/' at the start of the path within the sysroot)?

as in the attached trailing.diff? built and regression tested.

Yes, that's OK (with copyright date updates in incpath.c).

there is one more issue, when configuring


--with-sysroot=/ --with-gxx-include-dir=/usr/include/c++/4.7

in that the leading / is stripped away in configure.ac. This case needs an explicit check. Ok for the trunk?

Matthias

* configure.ac (gcc_gxx_include_dir): Don't strip a `/' sysroot value.

Attachment: gcc-sysroot.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]