Re: [Patch,AVR] Fix PR51345: split multilibs for SPH / no-SPH devices, Take #2

[Denis Chertykov <chertykov at gmail dot com>]

2011/12/19 Georg-Johann Lay <avr@gjlay.de>:
> Joseph S. Myers wrote:
>> On Sun, 18 Dec 2011, Georg-Johann Lay wrote:
>>
>>>> This new file needs to have the standard copyright and license notices.
>>>> It's desirable to generate such notices in the output files as well.
>>> What is the right copyright for the generated files?
>>
>> See other examples.
>
> There is more than one flavour if the license... From what you wrote it's okay
> to use GPL in all cases even if included libgcc, so I used that text.
>
> Besides printing license, there are two minor changes compared to the original
> patch:
>
> * lib1funcs.S defines macro SPEED_DIV that trades speed against code size.
> ÂIt uses __AVR_HAVE_8BIT_SP__ now to get better estimation of flash size.
>
> * avr-c.c use AVR_HAVE_8BIT_SP instead of avr_current_device->short_sp to
> Âdefine respective built-in macros __AVR_HAVE_8/16BIT_SP__.
>
> Ok?
>
> Johann
>
> contrib/
> Â Â Â ÂPR target/51345
> Â Â Â Â* gcc_update (files_and_dependencies): Add
> Â Â Â Âgcc/config/avr/t-multilib, gcc/config/avr/multilib.h.
>
> libgcc/
> Â Â Â ÂPR target/51345
> Â Â Â Â* config/avr/lib1funcs.S: Remove FIXME comments.
> Â Â Â Â(SPEED_DIV): Depend on __AVR_HAVE_8BIT_SP__.
> gcc/
> Â Â Â ÂPR target/51345
> Â Â Â Â* config.gcc (tm_file target=avr]): Add avr/avr-multilib.h
> Â Â Â Â(tmake_file target=avr): Add avr/t-multilib.
>
> Â Â Â Â* config/avr/avr-c.c (avr_cpu_cpp_builtins): Use AVR_HAVE_8BIT_SP
> Â Â Â Âto built-in define __AVR_HAVE_8BIT_SP__, __AVR_HAVE_16BIT_SP__.
> Â Â Â Â* config/avr/genmultilib.awk: New file.
> Â Â Â Â* config/avr/t-multilib: New auto-generated file.
> Â Â Â Â* config/avr/multilib.h: New auto-generated file.
> Â Â Â Â* config/avr/t-avr (AVR_MCUS): New variable.
> Â Â Â Â(genopt.sh): Use it.
> Â Â Â Â(s-mlib): Depend on t-multilib.
> Â Â Â Â(t-multilib, multilib.h): New dependencies.
> Â Â Â Â(s-avr-mlib): New rule to build t-multilib, multilib.h from AVR_MCUS.
> Â Â Â Â(MULTILIB_OPTIONS): Remove.
> Â Â Â Â(MULTILIB_MATCHES): Remove.
> Â Â Â Â(MULTILIB_DIRNAMES): Remove.
> Â Â Â Â(MULTILIB_EXCEPTIONS): Remove:
> Â Â Â Â* config/avr/genopt.sh: Don't use hard coded file name;
> Â Â Â Âpass AVR_MCUS from t-avr instead.
>

Approved.

Denis.