This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [google] Patch to enable efficient function level instrumentation (issue 5416043)
- From: davidxl at google dot com
- To: harshit at google dot com, dnovillo at google dot com, iant at google dot com, ccoutant at google dot com
- Cc: gcc-patches at gcc dot gnu dot org, reply at codereview-hr dot appspotmail dot com
- Date: Fri, 16 Dec 2011 21:43:02 +0000
- Subject: Re: [google] Patch to enable efficient function level instrumentation (issue 5416043)
- Reply-to: harshit at google dot com, dnovillo at google dot com, iant at google dot com, davidxl at google dot com, ccoutant at google dot com, gcc-patches at gcc dot gnu dot org, reply at codereview-hr dot appspotmail dot com
http://codereview.appspot.com/5416043/diff/12001/gcc/config/i386/i386.c
File gcc/config/i386/i386.c (left):
http://codereview.appspot.com/5416043/diff/12001/gcc/config/i386/i386.c#oldcode10928
gcc/config/i386/i386.c:10928: if (current_function_decl != NULL_TREE &&
I am not sure how the hack you have here makes the linker warning go
away (and besides the section name suffix will be stripped right after
it is set when switch_section is called). The right solution might be
to set the comdat group of the label address section to be the same as
the group of the comdat function.
Cary, what is your opinion?
http://codereview.appspot.com/5416043/