This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Copy over REG_ARGS_SIZE notes in sel-sched (PR debug/51557)


On 16.12.2011 11:53, Jakub Jelinek wrote:
On Fri, Dec 16, 2011 at 09:47:52AM +0400, Andrey Belevantsev wrote:
Thus, if an insn has any note that prevents it from being cloned, we
need to fix the above place.  (If an insn should not even be moved
from its block, then CANT_MOVE should be set to 1 in the same
function.)  Then create_copy_of_insn_rtx can safely copy all the
notes as we already know that only clonable insns get to this
function. The REG_EQUAL/REG_EQUIV notes may be dropped -- I thought
these are supposed to be recomputed by df these days, am I wrong?

REG_DEAD/REG_UNUSED notes are recomputed by df, I don't think anything recomputes REG_EQUAL/REG_EQUIV.

Eric agrees with you, so the patch is OK. Thanks for the patch and for enlightening me. And please feel free to CC/assign me on any PRs mentioning selective scheduler.

Andrey



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]