Re: [Patch PPC/Darwin] some tidy-ups for save_world (and a prelude to splitting it out of the rs6000 code).

[Iain Sandoe <developer at sandoe-acoustics dot co dot uk>]

Hi David, Mike,
On 10 Dec 2011, at 23:57, David Edelsohn wrote:

> On Sun, Dec 4, 2011 at 3:23 PM, Iain Sandoe
> <developer@sandoe-acoustics.co.uk> wrote:
>
> gcc:
>
>       * config/rs6000/rs6000.c (first_altivec_reg_to_save): Amend  
> comment.
>       (compute_vrsave_mask): Likewise.
>       (rs6000_emit_prologue): Move update of VRSave mask to  
> save_world()
>       when that is in use.
>
> libgcc:
>
>       * config/rs6000/darwin-world.S (toplevel): Make it clear that
> this function is
>       not used for PPC64.  (save_world): Amend comments.  Update the  
> VRsave
>       mask to reflect the saved regs.
>       (rest_world): Update comments, do not  clobber r10, do not use  
> r8.
>       (eh_rest_world_r10): Amend comments, do not use r8.
>       (rest_world_eh_r7r8): Make local, move restore of CR and  
> target address
>       to end of routine, do not use r8.
>
> > OK for trunk?
>
> Okay.
>
> It probably would be helpful to add a comment that rest_world_eh_r7r8
> has "r8" in the name for backward compatibility.

I renamed it as Lrest_world_eh_r7.
Committed with amendments for Mike's and your comments as attached,
Iain

Attachment: 182375-darwin-world-tidies.txt
Description: Text document