This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch PR libstdc++/51135]: Fix [4.7 Regression] SIGSEGV during exception cleanup on win32

2011/12/12 Paolo Carlini <paolo.carlini@oracle.com>:
> On 12/12/2011 12:11 PM, Kai Tietz wrote:
>>
>> Hi,
>>
>> so as no other review happend, I changed patch as you suggested.
>
> Well, sorry for not noticing earlier, but here, as in many other cases, I
> think it would be much cleaner to have the pre-processor games in the mingw
> config header, define a macro name there (normally undefined) and then use
> it here.
>
> Paolo.

Well, this was my initial attempt to solve it. The issue here is that
libsupc++ doesn't use the the os-header-file and I am not sure if it
is wise to introduce it here.  To add it to the cxxabi.h header, which
claims to reflect ABI issue, looks sensible as alternative to me here.

Kai
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]