This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch PPC/Darwin] some tidy-ups for save_world (and a prelude to splitting it out of the rs6000 code).
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Iain Sandoe <developer at sandoe-acoustics dot co dot uk>
- Cc: Mike Stump <mrs at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 10 Dec 2011 18:57:52 -0500
- Subject: Re: [Patch PPC/Darwin] some tidy-ups for save_world (and a prelude to splitting it out of the rs6000 code).
- References: <BF1FB947-2ACC-499C-B093-8E3A57D15D1D@sandoe-acoustics.co.uk> <709069DD-7ABC-4212-9E37-08AE9BBEA7B7@comcast.net> <2A206914-6A78-4F47-A7D0-F06BCC7CFD4A@sandoe-acoustics.co.uk>
On Sun, Dec 4, 2011 at 3:23 PM, Iain Sandoe
<developer@sandoe-acoustics.co.uk> wrote:
gcc:
* config/rs6000/rs6000.c (first_altivec_reg_to_save): Amend comment.
(compute_vrsave_mask): Likewise.
(rs6000_emit_prologue): Move update of VRSave mask to save_world()
when that is in use.
libgcc:
* config/rs6000/darwin-world.S (toplevel): Make it clear that
this function is
not used for PPC64. (save_world): Amend comments. Update the VRsave
mask to reflect the saved regs.
(rest_world): Update comments, do not clobber r10, do not use r8.
(eh_rest_world_r10): Amend comments, do not use r8.
(rest_world_eh_r7r8): Make local, move restore of CR and target address
to end of routine, do not use r8.
> OK for trunk?
Okay.
It probably would be helpful to add a comment that rest_world_eh_r7r8
has "r8" in the name for backward compatibility.
Thanks, David