This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: PR bootstrap/51479: Missing dependency on errors.o causes bootstrap failure
- From: Richard Guenther <richard dot guenther at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 9 Dec 2011 10:40:52 +0100
- Subject: Re: PATCH: PR bootstrap/51479: Missing dependency on errors.o causes bootstrap failure
- References: <20111209061733.GA4500@intel.com>
On Fri, Dec 9, 2011 at 7:17 AM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> gcc/Makefile.in has
>
> gengtype$(exeext) : gengtype.o gengtype-lex.o gengtype-parse.o \
> ? ? ? ? ? ? ?gengtype-state.o version.o errors.o $(LIBDEPS)
> ? ? ? ?+$(LINKER) $(ALL_LINKERFLAGS) $(LDFLAGS) -o $@ \
> ? ? ? ? ? ?$(filter-out ($LIBDEPS), $^) $(LIBS)
>
> However, there is no errors.o dependency, which leads to random
> parallel build failures. ?This patch adds errors.o dependency. ?OK
> for trunk and release branches?
Ok. (the 4.5 and 4.6 branches already have dependencies for error.o,
did they get lost somehow? Consider placing the error.o dependency
at the same old place to ease diffs)
Thanks,
Richard.
> Thanks.
>
> H.J.
> ---
> 2011-12-08 ?H.J. Lu ?<hongjiu.lu@intel.com>
>
> ? ? ? ?PR bootstrap/51479
> ? ? ? ?* Makefile.in (errors.o): New.
>
> diff --git a/gcc/Makefile.in b/gcc/Makefile.in
> index ae4f4da..83f70fa 100644
> --- a/gcc/Makefile.in
> +++ b/gcc/Makefile.in
> @@ -3947,6 +3947,8 @@ build/genautomata$(build_exeext) : BUILD_LIBS += -lm
> ?build/gengtype$(build_exeext) : build/gengtype-lex.o build/gengtype-parse.o \
> ? ? ? ? ? ? ? build/gengtype-state.o build/version.o build/errors.o
>
> +errors.o : errors.c $(CONFIG_H) $(SYSTEM_H) errors.h
> +
> ?gengtype$(exeext) : gengtype.o gengtype-lex.o gengtype-parse.o \
> ? ? ? ? ? ? ? gengtype-state.o version.o errors.o $(LIBDEPS)
> ? ? ? ?+$(LINKER) $(ALL_LINKERFLAGS) $(LDFLAGS) -o $@ \