This is the mail archive of the
mailing list for the GCC project.
Re: [Patch, Fortran] PR 48887 [4.7] Don't mark SELECT TYPE selector as allocatable/pointer
- From: Tobias Burnus <burnus at net-b dot de>
- To: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- Cc: gcc patches <gcc-patches at gcc dot gnu dot org>, gfortran <fortran at gcc dot gnu dot org>
- Date: Sat, 03 Dec 2011 19:31:43 +0100
- Subject: Re: [Patch, Fortran] PR 48887 [4.7] Don't mark SELECT TYPE selector as allocatable/pointer
- References: <4EDA3AE4.firstname.lastname@example.org> <CAGkQGiLMc-uftxMbZC_zCDiXQcr3+CxgSQGbZMxM+KNbFJHCLg@mail.gmail.com>
Paul Richard Thomas wrote:
Are you checking to see if the patches really are reviewed :-)
I am - but involuntarily. I am sure that I build and regtested - but
seemingly a different tree :-(
The latter change gets rejected with my class array patch in place
because I have:
I am really looking forward to have that patch in the trunk - it makes
patch writing and testing easier if one does not have two separate
trees, one clean with minor patches and one with your patch and
occasionally some on-top patches.
This is OK:
c->attr.pointer = attr->pointer || (attr->allocatable ? 0 : attr->dummy)
I have now used
|| (attr->dummy && !attr->allocatable)
|| (attr->allocatable ? 0 : attr->dummy)
which I found more readable.
I did also did a rebuild, regtested it and committed the patch as Rev.
Thanks for the careful review!