This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2, libcpp] Support expansion of reserved locations wrapped in virtual locations

From: Jason Merrill <jason at redhat dot com>
To: Dodji Seketeli <dodji at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org, tromey at redhat dot com
Date: Sat, 22 Oct 2011 10:43:59 -0400
Subject: Re: [PATCH 1/2, libcpp] Support expansion of reserved locations wrapped in virtual locations
References: <1319240276-26273-1-git-send-email-dodji@redhat.com> <1319240276-26273-2-git-send-email-dodji@redhat.com>

On 10/21/2011 07:37 PM, Dodji Seketeli wrote:

It also makes linemap_expand_location_full to return the location it
resolved to.

I think I'd prefer to have expand_location call linemap_resolve_location and then linemap_expand_location, and perhaps remove linemap_expand_location_full.

Incidentally, I notice that there's no assert to enforce the requirement that linemap_expand_location only takes spelling locations.

Jason

Follow-Ups:
- Re: [PATCH 1/2, libcpp] Support expansion of reserved locations wrapped in virtual locations
  - From: Dodji Seketeli

References:
- [PATCH 0/2, libcpp] Fix virtual location expansion and macro map lookup
  - From: Dodji Seketeli
- [PATCH 1/2, libcpp] Support expansion of reserved locations wrapped in virtual locations
  - From: Dodji Seketeli

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]