This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: Improve tree-ssa-sink block selection
- From: Jeff Law <law at redhat dot com>
- To: Paolo Bonzini <bonzini at gnu dot org>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 19 Oct 2011 23:48:25 -0600
- Subject: Re: RFA: Improve tree-ssa-sink block selection
- References: <4E9D0A45.1040307@redhat.com> <4E9D2E6A.2090405@gnu.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/18/11 01:44, Paolo Bonzini wrote:
> On 10/18/2011 07:10 AM, Jeff Law wrote:
>> --- 467,475 ---- if (gimple_code (use) != GIMPLE_PHI) { sinkbb =
>> gimple_bb (use); ! sinkbb = select_best_block (frombb,
>> gimple_bb (use), stmt);
>>
>> ! if (sinkbb == frombb) return false;
>>
>> *togsi = gsi_for_stmt (use);
>
> Useless assignment of sinkbb, otherwise looks fine.
I've removed the useless assignment and re-tested everything with no
regressions. I'm actually taking a few days off, so I'll check in the
updated patch after I return.
jeff
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJOn7YpAAoJEBRtltQi2kC78/sH/0LVTMn8x2EUnOgKIZL8Acgk
eYX7Er/cZZRkOUqtwdmwJNqqoNDVr3/0vS1JWnIGL9PvlEbpfb8AwLuUGlN6806x
iKbKVJGFHJ1LTSpxeebf2vI+R+0Ti8otkve01hcnq2rSOBv1j5C1MqhjuBeVlILs
ud0+zy7QxJRBr7YbXHaHN6ncJ+MqPYSDiWnwpvj9Obp6E/vDBc7biaaYSm08Pow/
G4gs3V3akjG3d/nP8XlgCucpJABZTmLpALrrV+s49AQKaARy+kVPfsRhIC8x3axL
MpXWLg9t8ZqRdW5pqAAQCbSTrKNPwX80NMvNFYqQjYU5HArNAZtoGffoQ6K158s=
=1D9Q
-----END PGP SIGNATURE-----