This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ARM] Fix PR49641


On 14/10/11 14:31, Bernd Schmidt wrote:
> On 07/13/11 16:03, Richard Earnshaw wrote:
>>> 	* config/arm/arm.c (store_multiple_sequence): Avoid cases where
>>> 	the base reg is stored iff compiling for Thumb1.
>>>
>>> 	* gcc.target/arm/pr49641.c: New test.
> 
> Ping.  Richard, you replied to the mail but didn't comment on the patch.
> 
> 
> Bernd
> 


Sorry, I thought I'd made it clear that I don't think the compiler
should ever use STM with write-back if the base register is in the
stored list.  We must certainly never do it if the base register is not
the first register in the list as this has always been unpredictable.

BTW, this is not Thumb1 specific, it applies at all times.


So, no the patch is not OK as it stands.

R.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]