Re: patch ping: thread testing infrastructure

[Jeff Law <law at redhat dot com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/04/11 08:43, Aldy Hernandez wrote:
> http://gcc.gnu.org/ml/gcc-patches/2011-09/msg01272.html
So others have already mentioned the name "memmodel" as being
unsatisfactory...  From the list, I liked simulate-thread (before
looking at your message where you voted for simulate-thread).

in memmodel-gdb-test, is there any reasonable way to detect if we're
not exactly 3 frames down from dg-test and that the local variable
"name" holds the filename of hte testcase?  Are these requirements
documented anywhere?

In the same code, don't you want to use somethign other than
GUALITY_GDB_NAME?  Clearly we've got two gcc testing frameworks that
need gdb.  A generic name might work better GDB_FOR_GCC_TESTING?  Or
something like that.

In remote_expect_target, don't you need to reorder the cases to have
the too-old-gdb case first.  Otherwise you can get inconsistent
results due to the way matching works in tcl/expect.  On a larger
note, can you use the routines from gcc-gdb-test.exp rather than
duplicating it?


In memmodel/guality.h, rather than including guality.h, would it make
sense to move the bits into a centralized place for use by any GCC
testing framework that wants to fire up gdb?

In memmodel.exp, do we really want to contiue to have references to
guality (check_guality, GUALITY_GDB_NAME, GUALCHKVAL)?  Is any of
those commonizable with the guality framework?


Do we have allow-store-data-races as a parameter in GCC right now?  If
not you'll need to do something about the tests themselves.


It's mostly OK -- just those nits related to copying the guality
stuff.  tcl may not make it feasible to share as much between guality
and simulate-thread as we'd like.


Jeff
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJOi1NTAAoJEBRtltQi2kC7zOAIALYCVEDV/jjzDEe9p41zdZe1
jjkEDlzPI58Gv3Z5gg1ueb4JOjTMKFepMwNb4qcIA45XViIPMCXtxZB411+Uvem9
xAqSOZlnauFspoa0zRUBlMRoozK+WIYsNnrx0KXj6xcWG2IF+843x/mUZFbT94fR
f2MBpbeRbFd5C/tEJShs1QZBbE+7tBC73Yf1L/u4vNGi38L9KLDRsbbKrvW0sQkC
16feM1srnZj0c4ZyUwdzfONi3JkIMc3Gt+s0c3TcwM9UtLQKGCEqy5H4rNjk65zb
PSKSDKkTVpK3QvqvDJTGycYgFzaKB/oM8oIjU+KLo+9x/al8SReZet0cP5N2bl4=
=Eeaa
-----END PGP SIGNATURE-----