Re: [PR 47382] We cannot simply fold OBJ_TYPE_REF at all in 4.6

[Maxim Kuvyrkov <maxim at codesourcery dot com>]

On 30/09/2011, at 6:56 PM, Maxim Kuvyrkov wrote:

> On 30/09/2011, at 4:02 PM, Maxim Kuvyrkov wrote:
> 
>> On 24/09/2011, at 2:19 AM, Martin Jambor wrote:
>> 
>>> However, both of these are really 4.8 material and since the patches
>>> probably need only minor updates, it might be worthwhile to do that so
>>> that gcc can handle the "embarrassing" simple cases.  So I will do
>>> that (though it might need to wait for about a week), re-try them on
>>> Firefox and probably propose them for submission.
>> 
>> Great!  Thank you.
> 
> Here is one of your patches updated to the latest mainline.  Just add water^W changelog.
> 
> It bootstraps, and I'm regtesting it on x86_64-linux-gnu {-m64,-m32} now.

Attached is a follow up patch to your 2 devirtualization patches.  Now that compute_known_type_jump_func may be called with SSA_NAME argument (from ipa_try_devirtualize_immediately) we need to make it handle SSA_NAMEs.

One way to do so it to defer the job to detect_type_change_ssa, below patch implements this approach.  Note that the patch relies on detect_type_change to initialize JFUNC, as is done in your patch at http://gcc.gnu.org/ml/gcc-patches/2011-01/msg01033.html.  Without that patch we need to initialize JFUNC inside compute_known_type_jump_func, which may be a cleaner solution.

I encourage you to include this small fix in the main body of one of your patches and claim credit for it.  You will spare me a test-submission cycle that way :-).

Thank you,

--
Maxim Kuvyrkov
CodeSourcery / Mentor Graphics

Attachment: fsf-gcc-devirt-pointers.ChangeLog
Description: Binary data

Attachment: fsf-gcc-devirt-pointers.patch
Description: Binary data