This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, Fortran] PR 41733: Proc-pointer conformance checks: Elemental-proc-ptr => non-elemental-proc


On Wed, Sep 21, 2011 at 10:27:34PM +0200, Janus Weil wrote:
> Hi all,
> 
> here is a patch which adds checks for the ELEMENTAL attribute in
> procedure pointer assignments and dummy procedures. For details see
> the PR and the c.l.f. thread mentioned therein. For the PURE
> attribute, we already had a check, which I moved and reformulated (so
> that it is applicable also to proc-ptr assignments).
> 
> The patch was regtested on x86_64-unknown-linux-gnu. Ok for trunk?
> 

OK.

The only nitpicking that I have is with Nonintrinsic in 

+         gfc_error ("Nonintrinsic elemental procedure '%s' is invalid "
+                    "in procedure pointer assigment at %L",
+                    rvalue->symtree->name, &rvalue->where);


I would probably use Non-intrinsic.

-- 
Steve


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]