Re: [patch] --enable-dynamic-string default for mingw-w64

[JonY <jon_y at users dot sourceforge dot net>]

On 9/20/2011 13:59, Kai Tietz wrote:
> 2011/9/20 JonY:
>> Hi,
>>
>> Its been used in the automated toolchain builds for sometime, seems like
>> a good idea to enable it by default. It can be easily changed to match
>> for all mingw as well if needed.
>>
>> OK for trunk?
>>
>> Index: libstdc++-v3/configure.ac
>> ===================================================================
>> --- libstdc++-v3/configure.ac   (revision 178946)
>> +++ libstdc++-v3/configure.ac   (working copy)
>> @@ -132,7 +132,15 @@
>>  GLIBCXX_ENABLE_DEBUG([no])
>>  GLIBCXX_ENABLE_PARALLEL([yes])
>>  GLIBCXX_ENABLE_CXX_FLAGS
>> -GLIBCXX_ENABLE_FULLY_DYNAMIC_STRING([no])
>> +case "$host" in
>> +  # Enable fully ynamic strings on mingw-w64 by default
>> +  i?86-w64-mingw* | x86_64-w64-mingw*)
>> +    GLIBCXX_ENABLE_FULLY_DYNAMIC_STRING([yes])
>> +    ;;
>> +  *)
>> +    GLIBCXX_ENABLE_FULLY_DYNAMIC_STRING([no])
>> +    ;;
>> +esac
>>  GLIBCXX_ENABLE_EXTERN_TEMPLATE([yes])
>>
>>  # Checks for operating systems support that doesn't require linking.
> 
> This patch looks reasonable to me. Note that this is no approval for
> it, as I'm not a libstdc++ maintainer.  But I can confirm that patch
> is ok from perspective of windows-target maintainer.
> Just one question I have here.  Why do we enable this option only for
> w64 flavor?  AFAIK is mingw.org also building their libstdc++ with
> enabling this configure-option
> 
> Kai
> 

Adding mingw-users to CC list.

OK "i?86-*-mingw* | x86_64-*-mingw*)" then, any mingw.org developers
care to comment?

Attachment: signature.asc
Description: OpenPGP digital signature