This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Replace tmp with __tmp
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, gcc-patches at gcc dot gnu dot org
- Date: Sat, 17 Sep 2011 11:51:25 +0200
- Subject: Re: PATCH: Replace tmp with __tmp
- References: <20110917004253.GA6149@intel.com> <m2d3ezwuh2.fsf@linux-m68k.org>
On Sat, Sep 17, 2011 at 8:31 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> diff --git a/gcc/config/i386/bmiintrin.h b/gcc/config/i386/bmiintrin.h
>> index af5d9dc..72ab114 100644
>> --- a/gcc/config/i386/bmiintrin.h
>> +++ b/gcc/config/i386/bmiintrin.h
>> @@ -42,8 +42,8 @@ __tzcnt_u16 (unsigned short __X)
>> ?extern __inline unsigned int __attribute__((__gnu_inline__, __always_inline__, __artificial__))
>> ?__andn_u32 (unsigned int __X, unsigned int __Y)
>> ?{
>> - ?unsigned int tmp = ~(__X) & (__Y);
>> - ?return tmp;
>> + ?unsigned int __tmp = ~(__X) & (__Y);
>> + ?return __tmp;
>
> How about just removing it? ?(And the parens are redundant, too.)
Agreed. Some parets are missing, though:
- unsigned long long tmp = (__X) ^ (__X - 1);
- return tmp;
+ unsigned long long __tmp = (__X) ^ (__X - 1);
+ return __tmp;
(__X) ^ ((__X) - 1)
Uros.