This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix Ada bootstrap failure

From: Eric Botcazou <ebotcazou at adacore dot com>
To: Richard Guenther <richard dot guenther at gmail dot com>
Cc: Richard Guenther <rguenther at suse dot de>, gcc-patches at gcc dot gnu dot org, vries at gcc dot gnu dot org
Date: Sat, 3 Sep 2011 11:09:48 +0200
Subject: Re: [PATCH] Fix Ada bootstrap failure
References: <alpine.LNX.2.00.1109021336341.2130@zhemvz.fhfr.qr> <201109021855.21785.ebotcazou@adacore.com> <CAFiYyc2cyzJAPR0V=eS1BWshrGqKJ5oG5nZi_p0DeU=kPL0HYw@mail.gmail.com>

> I'm not sure we want to create a the replacement decl with DECL_SIZE zero
> though, so I suppose instead of making sure align is BITS_PER_UNIT
> shouldn't we make sure that size is at least 1?  I fear we might run into
> other odd problems with zero-size autos.

The cfgexpand.c code already does so, see the top of the hunk.

> Thus, a variant of the patch that re-enables handling of size zero allocas
> but adjusts the size to be at least 1 is ok.

I think that the zero size is fine, we very likely generate this kind of 
things directly in Ada.

-- 
Eric Botcazou

Follow-Ups:
- Re: [PATCH] Fix Ada bootstrap failure
  - From: Richard Guenther

References:
- [PATCH] Fix Ada bootstrap failure
  - From: Richard Guenther
- Re: [PATCH] Fix Ada bootstrap failure
  - From: Eric Botcazou
- Re: [PATCH] Fix Ada bootstrap failure
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]