This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix PR50260
On Fri, Sep 2, 2011 at 8:40 PM, Michael Matz <matz@suse.de> wrote:
> Hi,
>
> On Fri, 2 Sep 2011, Michael Matz wrote:
>
>> Hi,
>>
>> On Fri, 2 Sep 2011, Richard Guenther wrote:
>>
>> > > Currently regstrapping on x86_64-linux (without Ada). ?Okay for trunk?
>> >
>> > Ok. ?Time to make get_var_ann private?
>>
>> Yes. ?Should the regstrap succeed on x86_64-linux I'll commit this
>> variant of the patch (hunks in tree-flow.h, tree-flow-inline.h and
>> tree-dfa.c are new, otherwise the same patch).
>
> As I feared the call to get_var_ann in set_is_used right now really is
> still needed, privatizing it hence isn't that straight forward. ?For now
> I've committed the PR50260 fix without that cleanup as r178489 to fix
> bootstrap for some platforms.
That's odd though - looking at the single caller it should only ever
be called for referenced vars - which means we miss a referenced var
somewhere.
Richard.
>
> Ciao,
> Michael.