This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Ada] Implementation of aspects within generic units
- From: Tom de Vries <vries at codesourcery dot com>
- To: Richard Guenther <richard dot guenther at gmail dot com>
- Cc: Arnaud Charlet <charlet at adacore dot com>, Tom de Vries <tom at codesourcery dot com>, Iain Sandoe <developer at sandoe-acoustics dot co dot uk>, "Joseph S. Myers" <joseph at codesourcery dot com>, Eric Botcazou <botcazou at adacore dot com>, Olivier Hainque <hainque at adacore dot com>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 01 Sep 2011 13:01:57 +0200
- Subject: Re: [Ada] Implementation of aspects within generic units
- References: <CAFiYyc1rHYoQ5sDcYjxnZsdV1zoQKAMn=wc8p0ZhKZ8dmABU7g@mail.gmail.com> <20110831111610.GA49689@adacore.com> <CAFiYyc1J6Y6XCLndoqCuWT8tyXnAn3SwhtsXZ9-mrJW_ZZ58jw@mail.gmail.com> <20110831150740.GC83109@adacore.com> <Pine.LNX.4.64.1108311551150.381@digraph.polyomino.org.uk> <20110831155718.GB90456@adacore.com> <58487A02-7DE9-48DD-BAFB-D2DC4A61156B@sandoe-acoustics.co.uk> <20110831163434.GA95956@adacore.com> <CAFiYyc3Q4imawytjov5Jx5JhQDQBALxKj8Pi-qOeqNm+pVDykw@mail.gmail.com> <CAFiYyc2ecnc8FCZAcB49jELoJ-mNAwXzc=M2WeGW9bA56US47w@mail.gmail.com> <20110901093440.GA20263@adacore.com> <CAFiYyc1VkmrUckAR5GzBg5hzAjF9sHeEK3beTjXLwZ--duAVNQ@mail.gmail.com>
On 09/01/2011 12:33 PM, Richard Guenther wrote:
> On Thu, Sep 1, 2011 at 11:34 AM, Arnaud Charlet <charlet@adacore.com> wrote:
>> After doing a binary search, the first revision which breaks bootstrap on
>> my environment with Ada enabled is the following:
>>
>> r178353 | vries | 2011-08-31 09:04:25 +0200 (Wed, 31 Aug 2011) | 8 lines
>>
>> 2011-08-31 Tom de Vries <tom@codesourcery.com>
>>
>> PR middle-end/43513
>> * Makefile.in (tree-ssa-ccp.o): Add $(PARAMS_H) to rule.
>> * tree-ssa-ccp.c (params.h): Include.
>> (fold_builtin_alloca_for_var): New function.
>> (ccp_fold_stmt): Use fold_builtin_alloca_for_var.
>>
>> Which makes sense, since Ada uses alloca a lot, much more than other languages.
>>
>> In other words, none of the changes in the Ada repository is reponsible for
>> this regression.
>>
>> So Tom and/or Richard, could you please have a look at this regression? TIA.
>
> Probably worth checking
>
> Index: gcc/tree-ssa-ccp.c
> ===================================================================
> --- gcc/tree-ssa-ccp.c (revision 178394)
> +++ gcc/tree-ssa-ccp.c (working copy)
> @@ -1714,7 +1714,7 @@ fold_builtin_alloca_for_var (gimple stmt
> block = gimple_block (stmt);
> if (!(cfun->after_inlining
> && TREE_CODE (BLOCK_SUPERCONTEXT (block)) == FUNCTION_DECL))
> - threshold /= 10;
> + return NULL_TREE;
> if (size > threshold)
> return NULL_TREE;
>
> should be reproducable with low stack ulimit.
>
> Richard.
>
>> Arno
>>
I'm doing an ada bootstrap now, trying to reproduce this. My apologies for this
breakage.
Thanks,
- Tom