This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR49799: Don't generate illegal bit field extraction instruction


On Thu, Jul 28, 2011 at 04:40:53PM +0800, Carrot Wei wrote:
> ChangeLog:
> 2011-07-28  Wei Guozhi  <carrot@google.com>
> 
>         PR rtl-optimization/49799
>         * pr49799.c : New test case.

Space shouldn't be between .c and :.  And the filename should be
relative to gcc/testsuite/ dir, so either gcc.target/arm/pr49799.c, or
better gcc.dg/pr49799.c.

Putting the testcase just into gcc.target/arm means it won't be tested
on other targets, while there is nothing arm specific about the testcase
except that you force -march in dg-options for arm.
You can do that with
/* PR rtl-optimization/49799 */
/* { dg-do assemble } */
/* { dg-options "-O2 -w" } */
/* { dg-options "-O2 -w -march=armv7-a" { target arm*-*-* } } */
or similar.

Ok with those changes.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]