This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Move pr49309.C testcase to libmudflap (PR testsuite/49753)
On Mon, Jul 18, 2011 at 12:22:01PM +0200, Rainer Orth wrote:
> >> The problem here is that the type of the POINTER_PLUS_EXPR is
> >> incorrect and also the non folded version leaks to the IR. This patch
> >> fixes those two problems and fixes the ICE.
> >>
> >> OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions.
> >
> > The testcase is wrongly placed and thus fails everywhere. -fmudflap
> > causes inclusion of headers and gcc/testsuite/ isn't set up to find them.
>
> There's a far simpler fix, inspired by gcc.dg/dfp/pr35739.c. I think it
> is better since it gives the testcase wider coverage. Tested with the
> appropriate runtest invocation on i386-pc-solaris2.11 and
> alpha-dec-osf5.1b.
libmudflap testsuite also iterates over different -O* options and it is IMHO
better to keep mudflap tests together. But I don't feel too strongly about
it.
Jakub