This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [v3] libstdc++/49745 (review required for the gthr-posix.h changes)

From: Jason Merrill <jason at redhat dot com>
To: Paolo Carlini <paolo dot carlini at oracle dot com>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, libstdc++ <libstdc++ at gcc dot gnu dot org>, Jakub Jelinek <jakub at redhat dot com>, Ian Lance Taylor <iant at google dot com>
Date: Fri, 15 Jul 2011 09:36:48 -0400
Subject: Re: [v3] libstdc++/49745 (review required for the gthr-posix.h changes)
References: <4E2036FA.8020901@oracle.com>

On 07/15/2011 08:47 AM, Paolo Carlini wrote:

The patch should be in general quite conservative and safe, in
particular, the gthr-posix.h changes, which I cannot approve myself,
touch bits only used by libstdc++-v3 + the macro avoiding the
unconditional inclusion of <unistd.h>, which, according to Jakub's
analysis, should be required only by objc.

I'm a little uncomfortable with defining a macro in libstdc++ to be used by the gthr files in gcc. I would lean more toward a gthr-posix-conf.h generated by GCC configure.

Jason

Follow-Ups:
- Re: [v3] libstdc++/49745 (review required for the gthr-posix.h changes)
  - From: Paolo Carlini
- Re: [v3] libstdc++/49745 (review required for the gthr-posix.h changes)
  - From: Jakub Jelinek

References:
- [v3] libstdc++/49745 (review required for the gthr-posix.h changes)
  - From: Paolo Carlini

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]